Skip to content

Add SQLAlchemy dependency to Exasol provider (#59902) #59915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Jkhall81 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add SQLAlchemy dependency to Exasol provider (#59902) #59915

Jkhall81 wants to merge 2 commits into from
+21 −2

Conversation

@Jkhall81
Copy link

@Jkhall81 Jkhall81 commented Dec 29, 2025 •
edited
Loading

Add SQLAlchemy dependency to Exasol provider

closes: #59902

Summary

This PR makes sqlalchemy an optional dependency for the Exasol provider to support the upcoming Task SDK isolation in Airflow 3.0.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Jkhall81 Jkhall81 force-pushed the add-sqlalchemy-dep-exasol-59902 branch from 5315fe3 to b2a36d9 Compare December 30, 2025 01:46
sunank200
sunank200 reviewed Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mark SQLAlchemy as optional dependency in Exasol pyproject as well

providers/exasol/src/airflow/providers/exasol/hooks/exasol.py
:return: the extracted sqlalchemy.engine.URL object.
"""
if URL is None:
raise AirflowOptionalProviderFeatureException(
Copy link
Collaborator

@sunank200 sunank200 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
raise AirflowOptionalProviderFeatureException(
raise AirflowOptionalProviderFeatureException(
"sqlalchemy is required for SQL filter clause generation. "
"Install it with: pip install 'apache-airflow-providers-exasol[sqlalchemy]'"
)

Copy link
Contributor

@jscheffl jscheffl Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case described above you need to add it as optional dependency in pyproject.toml as well.

Copy link
Author

@Jkhall81 Jkhall81 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jscheffl I added a [project.optional-dependencies] section to the pyproject.toml. I greped around and found an example where this is used, so I think I got the format right.

@sunank200 Regarding the error message: I went ahead and left the error message as is for now. Since in this file sqlalchemy is being used to generate a DB connection URI. Mentioning 'SQL filter clauses' might be a little confusing.

@Jkhall81 Jkhall81 force-pushed the add-sqlalchemy-dep-exasol-59902 branch from b2a36d9 to f4391e6 Compare December 30, 2025 12:36
potiuk
potiuk reviewed Dec 30, 2025
View reviewed changes
@Jkhall81 @potiuk
Update providers/exasol/pyproject.toml
5d05262 
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk left review comments

@jscheffl jscheffl jscheffl left review comments

+1 more reviewer

@sunank200 sunank200 sunank200 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area:providers kind:documentation provider:exasol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add proper dependencies for sqlalchemy - exasol

4 participants

@Jkhall81 @potiuk @sunank200 @jscheffl